Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow Sudo to change admin key in pallet service_request #352

Merged
merged 2 commits into from
Sep 19, 2022
Merged

fix: allow Sudo to change admin key in pallet service_request #352

merged 2 commits into from
Sep 19, 2022

Conversation

abdulhakim2902
Copy link
Contributor

@abdulhakim2902 abdulhakim2902 commented Sep 12, 2022 •
edited
Loading

JIRA LINK

Changelog

  • Improved code readability
  • Allow sudo to change admin key

@abdulhakim2902 abdulhakim2902 self-assigned this Sep 12, 2022
@abdulhakim2902 abdulhakim2902 changed the title fix: improved code readability fix: Enhance logic function process_request in extrinsic service_request Sep 13, 2022
@abdulhakim2902 abdulhakim2902 force-pushed the service-request branch 5 times, most recently from c446179 to a059977 Compare September 19, 2022 05:46
@abdulhakim2902 abdulhakim2902 changed the title fix: Enhance logic function process_request in extrinsic service_request fix: Aallow Sudo to change admin key in pallet service_request Sep 19, 2022
@abdulhakim2902 abdulhakim2902 changed the title fix: Aallow Sudo to change admin key in pallet service_request fix: Allow Sudo to change admin key in pallet service_request Sep 19, 2022
@abdulhakim2902 abdulhakim2902 changed the title fix: Allow Sudo to change admin key in pallet service_request fix: allow Sudo to change admin key in pallet service_request Sep 19, 2022
@abdulhakim2902 abdulhakim2902 marked this pull request as ready for review September 19, 2022 08:03
@irmannmal irmannmal merged commit 685a822 into debionetwork:main Sep 19, 2022
@abdulhakim2902 abdulhakim2902 deleted the service-request branch September 20, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irmannmal irmannmal irmannmal approved these changes

@agustinustheo agustinustheo Awaiting requested review from agustinustheo

@hilyds hilyds Awaiting requested review from hilyds

Assignees

@abdulhakim2902 abdulhakim2902

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdulhakim2902 @irmannmal