Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: bench use lab verifier key as mock. #149

Merged
merged 12 commits into from
Nov 12, 2021
Merged

tests: bench use lab verifier key as mock. #149

merged 12 commits into from
Nov 12, 2021

Conversation

agustinustheo
Copy link
Contributor

@agustinustheo agustinustheo commented Nov 11, 2021 •
edited
Loading

JIRA Link

Changelog / Description

  • Fix labs benchmark.

Dependency

@agustinustheo agustinustheo added fix Something isn't working test Create or edit tests for features. improvement labels Nov 11, 2021
@agustinustheo agustinustheo requested a review from hilyds November 11, 2021 19:40
@agustinustheo agustinustheo self-assigned this Nov 11, 2021
@agustinustheo
Copy link
Contributor Author

Note to @hilyds please just check the last commit in this PR, the rest are duplicates of #147

@agustinustheo
Copy link
Contributor Author

Please merge this PR beforehand: #147

hilyds
hilyds approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@hilyds hilyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agustinustheo agustinustheo merged commit bc0bc70 into debionetwork:main Nov 12, 2021
@agustinustheo agustinustheo deleted the fix-benchmark branch November 12, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hilyds hilyds hilyds approved these changes

Assignees

@agustinustheo agustinustheo

Labels
fix Something isn't working improvement test Create or edit tests for features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agustinustheo @hilyds