Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key mappings for Kana, Eisu_toggle and Muhenkan #832

Merged
merged 2 commits into from
Aug 22, 2020

Conversation

tom-tan
Copy link

@tom-tan tom-tan commented Aug 12, 2020

This request is a continuation of #818 to share Japanese keyboards with Windows and mac computers while keeping Japanese input functionalities.

Windows and mac provide similar but different keys to enable and disable Japanese input methods:

  • Disable Japanese input method: Muhenkan (Windows) <-> Eisu_toggle (mac)
  • Enable Japanese input method: Henkan (Windows) <-> Kana (mac)

Making a mapping of these keys is important to share the Japanese keyboards but unfortunately some of these keys are not recognized by barrier.

The request #818 added key entries for Eisu_toggle and Muhenkan to the barrier internal key representation.
This request adds a mapping between the internal representation with OS-specific key representation.

I confirmed that this request makes barrier aware of Kana, Eisu_toggle, Henkan and Muhenkan keys in the section: options section in the setting file.

After merging this request, we can smoothly share Japanese keyboards between Windows and mac computers by adding the following settings (in the case of Windows server):

section: options
        ...
	keystroke(Henkan) = ;keystroke(Kana,client)
	keystroke(Muhenkan) = ;keystroke(EisuToggle,client)
end

Note that GUI hotkey editor does not recognize these Japanese IME keys and therefore we have to edit the configuration file directly. Fixing it is out of scope of this request.

@tom-tan tom-tan changed the title Add key mappings for Kana, Eisu_toggle and Muhenkan WIP: Add key mappings for Kana, Eisu_toggle and Muhenkan Aug 17, 2020
@tom-tan tom-tan marked this pull request as draft August 17, 2020 12:25
@tom-tan tom-tan marked this pull request as ready for review August 17, 2020 12:36
@tom-tan
Copy link
Author

tom-tan commented Aug 17, 2020

I found that in the case of Windows server and mac client with the above example configuration, it works in mac client but I cannot enable and disable Japanese input method using Henkan and Muhenkan in Windows server.

However, I reproduce the same problem with keystroke(Control+a) = ;keystroke(Control+a,client).
Therefore it is not due to this request and it should be filed in another issue.

@tom-tan tom-tan changed the title WIP: Add key mappings for Kana, Eisu_toggle and Muhenkan Add key mappings for Kana, Eisu_toggle and Muhenkan Aug 17, 2020
@tom-tan
Copy link
Author

tom-tan commented Aug 18, 2020

I filed another blocker to share Japanese keyboards with Windows and mac computer while enabling/disabling Japanese input method using the same keys in #840.

@tom-tan
Copy link
Author

tom-tan commented Aug 19, 2020

ping!

Copy link
Member

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for working on this.

@p12tic p12tic merged commit b204520 into debauchee:master Aug 22, 2020
@tom-tan tom-tan deleted the add-os-barrier-keymap-for-jis-kbd branch August 27, 2020 06:37
@tom-tan
Copy link
Author

tom-tan commented Aug 27, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants