add support for keyboard backlight media keys #822
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tested this with a german Apple Magic Keyboard with Numeric Keypad (Space Gray) connected to a non-Apple Linux Laptop running Arch Linux. keycode 237 (keysym 0x1008ff06, XF86KbdBrightnessDown) keycode 238 (keysym 0x1008ff05, XF86KbdBrightnessUp)
|
We seem to already have the backlight key though. I assume you mean the existing key coded in doesn't work on your system? |
|
the keys weren't delivered to the remote system, yes. |
Oh! Duh. Yes, I misread.. just going to approve now, and merge - it looks fine to me as a dev. |
p12tic
added a commit
to p12tic/barrier
that referenced
this pull request
Jan 10, 2021
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.