Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten snap version on tagged revisions #797

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

maxiberta
Copy link

Hi! Congrats on the new release. Are there plans to release the snap for v2.3.3? Afaict, CI is pushing builds to edge, so it's just a matter of promoting the latest build to stable (maybe candidate first?).

Confusingly, the latest build on edge currently has version 2.3.2-122-g3395cca9 instead of just v2.3.3; not sure why it didn't catch the new tag. Maybe it was tagged after the snap was built? In any case, even if it had worked, the resulting snap version would've been 2.3.3-0-g3395cca9. This branch should improve that and make the next tagged release shorter.

If you merge this, the resulting snap build on edge should have version 2.3.3-1-g12345678. Maybe then it can just be promoted to candidate and/or stable?

@shymega
Copy link

shymega commented Jul 14, 2020

Hey,

I can merge this sure. I'd prefer for snaps to be tags without the long hash. With regards to the currently built snap - couldn't say why that would happen. I've not had anything to do with Snap builds.. I'll merge this for now.

@shymega shymega merged commit bbd1acc into debauchee:master Jul 14, 2020
@maxiberta
Copy link
Author

I can merge this sure. I'd prefer for snaps to be tags without the long hash. With regards to the currently built snap - couldn't say why that would happen. I've not had anything to do with Snap builds.. I'll merge this for now.

Auto-builds from master on the edge channel should use the long hash, imho; while candidate and stable are better for the short one. The proposed version string logic will do the right thing when building from a tag.

I believe the publisher of the snap is @AdrianKoshka, check https://snapcraft.io/barrier. They should be able to grant access to you or whoever needed to manage the snap releases.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants