Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Settings: Explain what "double tap" means #750

Merged
merged 1 commit into from
Jun 14, 2020

Conversation

nh2
Copy link

@nh2 nh2 commented Jun 14, 2020

It took me half an hour, and a look at the code, to figure out what "double tap" means. I thought it meant "click", so I tried clicking around on the screen edge but it wouldn't do anything. I think it's a bad translation; probably a better English word for the motion would be "bump" or "edge bump".

In any case, a detailed explanation is better. So this PR adds a label

Bump against the screen edge with the mouse pointer twice in quick succession.

Screenshot of what it looks like with my change:

image


I think this way of explaining it is better than a tool-tip or Qt's What's This functionality because most people don't know that those exist. An alternative would be to rename the setting from "tap" to "bump" (thus also changing the mnemonic key) and write on the settings screen something like "you can right-click each setting for a description of what it does" so that What's this is more discoverable, but I'd only do that after explaining the other settings as well, and that is more involved than this quick fix, which I think should be landed first.

@nh2
Copy link
Author

nh2 commented Jun 14, 2020

Also, it's really fantastic that you're reviving Synergy here. And it works well out of the box 👍

Copy link
Member

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@p12tic p12tic merged commit 2393393 into debauchee:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants