Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve efficiency of label translation in text format #124

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

RoadRunnr
Copy link
Contributor

Optimize label to string translation to avoid redundant work.

Experiments show a up to 50% improvement on large datasets.

@RoadRunnr RoadRunnr force-pushed the experimental/speedup branch 2 times, most recently from f400e63 to 5783fb3 Compare April 29, 2021 07:48
Avoid repeatedly formatting labels to strings. Reuse the parts that
are constant between list items.
@RoadRunnr RoadRunnr force-pushed the experimental/speedup branch from 5783fb3 to 26f52fa Compare April 29, 2021 07:50
@deadtrickster deadtrickster merged commit b38f87d into deadtrickster:master Apr 29, 2021
@deadtrickster
Copy link
Owner

Thank you for the patches!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants