Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Erlang 23 format for blocks entry in allocators #102

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Support Erlang 23 format for blocks entry in allocators #102

merged 1 commit into from
Feb 3, 2020

Conversation

dcorbacho
Copy link
Contributor

blocks_size has been removed, instead the count and size info is provided in blocks

{blocks,[{ll_alloc,[{count,1,1,1},{size,131144,131144,131144}]}]}

@deadtrickster deadtrickster requested a review from essen January 30, 2020 21:31
essen
essen approved these changes Feb 1, 2020
View reviewed changes
Copy link
Collaborator

@essen essen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can compare with similar changes done in Observer for example, from the commit that changed this in master: erlang/otp@608230a#diff-88857c9e5c14ac1790b2fcd208792df6

@deadtrickster
Copy link
Owner

as far as I can tell it's meant to be backwards compatible, right? Also build fails

@essen
Copy link
Collaborator

essen commented Feb 2, 2020

Yes that's what I meant, it's backward compatible. And yes, build fails. :-)

@dcorbacho
Copy link
Contributor Author

Thank you both, it's fixed now. I hadn't compiled it independently from rabbit..

@deadtrickster
Copy link
Owner

still red :-(

@dcorbacho dcorbacho force-pushed the erlang-23-allocators branch from 0ce2d79 to f9c7a22 Compare February 3, 2020 11:43
@essen
Copy link
Collaborator

essen commented Feb 3, 2020

Coverage necessarily decreases because the new code will only run in OTP 23.

@deadtrickster deadtrickster merged commit 73698ec into deadtrickster:master Feb 3, 2020
@deadtrickster
Copy link
Owner

Thanks!

@gerhard
Copy link
Collaborator

gerhard commented Mar 5, 2020

I am finally catching up on this. I've noticed that v4.5.0, the latest release currently available, does not include this change.

If this is backwards-compatible with OTP 22 & 21, are we waiting for anything else before we cut a new release? There is no rush from my perspective, just wondering.

gerhard added a commit to rabbitmq/rabbitmq-common that referenced this pull request Mar 6, 2020
@gerhard
Use dev prometheus.erl in RabbitMQ master (3.9.x)
018b1aa 
We want to test PRs such as
deadtrickster/prometheus.erl#102
in RabbitMQ master (3.9.x) so that we can test fixes against other
master components, like OTP 23 (erlang-git).

Signed-off-by: Gerhard Lazu <[email protected]>
@gerhard gerhard mentioned this pull request Apr 24, 2020
Merged
@gerhard gerhard mentioned this pull request May 15, 2020
Closed
michaelklishin added a commit to rabbitmq/erlang-rpm that referenced this pull request May 15, 2020
@michaelklishin
Add a note on RabbitMQ version compatibility
063c32a 
References

 * rabbitmq/rabbitmq-prometheus#42
 * rabbitmq/rabbitmq-prometheus#43
 * deadtrickster/prometheus.erl#102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@essen essen essen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcorbacho @deadtrickster @essen @gerhard