Skip to content

Commit

Permalink
ALSA: compress: Pass through return value of open ops callback
Browse files Browse the repository at this point in the history
The snd_compr_open function would always return 0 even if the compressed
ops open function failed, obviously this is incorrect. Looks like this
was introduced by a small typo in:

commit a0830db
ALSA: Add a reference counter to card instance

This patch returns the value from the compressed op as it should.

Signed-off-by: Charles Keepax <[email protected]>
Acked-by: Vinod Koul <[email protected]>
Cc: <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
charleskeepax authored and tiwai committed Mar 19, 2014
1 parent 3055644 commit 749d322
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/core/compress_offload.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ static int snd_compr_open(struct inode *inode, struct file *f)
kfree(data);
}
snd_card_unref(compr->card);
return 0;
return ret;
}

static int snd_compr_free(struct inode *inode, struct file *f)
Expand Down

0 comments on commit 749d322

Please sign in to comment.