Skip to content

Commit

Permalink
iommu/of: Don't call iommu_ops->add_device directly
Browse files Browse the repository at this point in the history
Make sure to invoke this call-back through the proper
function of the IOMMU-API.

Signed-off-by: Joerg Roedel <[email protected]>
  • Loading branch information
joergroedel committed Dec 17, 2018
1 parent cc5aed4 commit 641fb0e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/iommu/of_iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,10 @@ const struct iommu_ops *of_iommu_configure(struct device *dev,
}
/*
* If we have reason to believe the IOMMU driver missed the initial
* add_device callback for dev, replay it to get things in order.
* probe for dev, replay it to get things in order.
*/
if (ops && ops->add_device && dev->bus && !device_iommu_mapped(dev))
err = ops->add_device(dev);
if (dev->bus && !device_iommu_mapped(dev))
err = iommu_probe_device(dev);

/* Ignore all other errors apart from EPROBE_DEFER */
if (err == -EPROBE_DEFER) {
Expand Down

0 comments on commit 641fb0e

Please sign in to comment.