backport to node0.10 by using more of Nan #64
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 0.10 support appears to be dropped after v1.0.0 despite this module using nan. I'm trying to upgrade a codebase that's currently running on 0.10 but I need this module to work on both targets. This is my attempt at using nan almost exclusively where possible. Hopefully this will aid with adding support for future versions too. Note also that the callback signature in libuv is different between 0.x and 1.x, hence the version checks.