Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport to node0.10 by using more of Nan #64

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

Matt-Esch
Copy link
Contributor

Node 0.10 support appears to be dropped after v1.0.0 despite this module using nan. I'm trying to upgrade a codebase that's currently running on 0.10 but I need this module to work on both targets. This is my attempt at using nan almost exclusively where possible. Hopefully this will aid with adding support for future versions too. Note also that the callback signature in libuv is different between 0.x and 1.x, hence the version checks.

@kneth
Copy link
Collaborator

kneth commented Jun 11, 2019

@Matt-Esch Thank you for the contribution. I hope to have some time later this week to take a closer look.

@kneth
Copy link
Collaborator

kneth commented Jun 20, 2019

@Matt-Esch When compiling on macOS using clang/Xcode, I get the error:

clang: error: invalid deployment target for -stdlib=libc++ (requires OS X 10.7 or later)

Which operating system/compiler did you use?

@Matt-Esch
Copy link
Contributor Author

I'm using OSX and Xcode (Mojave 10.14.5 / Apple LLVM version 10.0.0 (clang-1000.11.45.5))

This change shouldn't make a difference to the basic compilation options. Which version of node are you testing with? If you're testing this with backcompat for node0.10 and using npm v2 or earlier, there is an issue with npm that sets the min version to 10.5, and support has long since been dropped. This can be resolved without upgrading npm by overriding the compiler flags:

export LDFLAGS="-mmacosx-version-min=10.9"
export CXXFLAGS="-mmacosx-version-min=10.9"

@kneth
Copy link
Collaborator

kneth commented Jun 24, 2019

@Matt-Esch Adding 'MACOSX_DEPLOYMENT_TARGET': '10.9', to the xcode_settings is doing the trick (see #66).

@kneth kneth merged commit 5f7d12d into ddopson:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants