Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal node 12 support #62

Merged
merged 4 commits into from
May 18, 2019
Merged

Minimal node 12 support #62

merged 4 commits into from
May 18, 2019

Conversation

kneth
Copy link
Collaborator

@kneth kneth commented May 15, 2019

Closes #61

I still get some warning when building for node 12 but for node 8.

@kneth kneth self-assigned this May 15, 2019
@abetomo
Copy link

abetomo commented May 18, 2019

When will it be released?

@kneth kneth merged commit 6c47b1f into master May 18, 2019
@kneth kneth deleted the kneth/node-12 branch May 18, 2019 17:15
@kneth
Copy link
Collaborator Author

kneth commented May 18, 2019

@abetomo @legraphista I have released v1.2.0 with node 12 support.

@abetomo
Copy link

abetomo commented May 19, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to build under Node 12
2 participants