Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the v8::String deprecation warning #58

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Fix the v8::String deprecation warning #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/segfault-handler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ NAN_METHOD(RegisterHandler) {
if (info.Length() > 0) {
for (int i = 0; i < info.Length(); i++) {
if (info[i]->IsString()) {
String::Utf8Value utf8Value(info[i]->ToString());
Nan::Utf8String utf8Value(info[i]);

// need to do a copy to make sure the string doesn't become a dangling pointer
int len = utf8Value.length();
Expand Down