Skip to content

Commit

Permalink
Merge pull request #58 from paul-maxime/fix/string-deprecation
Browse files Browse the repository at this point in the history
Fix the v8::String deprecation warning
  • Loading branch information
kneth authored Apr 30, 2019
2 parents 7249368 + 33cd8bf commit 80352f5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/segfault-handler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ NAN_METHOD(RegisterHandler) {
if (info.Length() > 0) {
for (int i = 0; i < info.Length(); i++) {
if (info[i]->IsString()) {
String::Utf8Value utf8Value(info[i]->ToString());
Nan::Utf8String utf8Value(info[i]);

// need to do a copy to make sure the string doesn't become a dangling pointer
int len = utf8Value.length();
Expand Down

0 comments on commit 80352f5

Please sign in to comment.