Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pre-download sqlite3 3.45.1 for Drupal 11, fixes #6807 #6817

Merged
merged 4 commits into from
Dec 8, 2024

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Dec 6, 2024

The Issue

Adding sqlite3 3.45.1 for everyone is not good because it can break some dependencies.

How This PR Solves The Issue

This PR pre-downloads *.deb for sqlite3 3.45.1 and installs it only for Drupal 11, the idea comes from:

It increases ddev-webserver size by 1 MB.

Manual Testing Instructions

ddev config --project-type=drupal11 && ddev restart && echo && ddev exec sqlite3 --version
3.45.1

ddev config --project-type=php && ddev restart && echo && ddev exec sqlite3 --version
3.40.1

Automated Testing Overview

Release/Deployment Notes

@stasadev stasadev requested a review from a team as a code owner December 6, 2024 12:30
@github-actions github-actions bot added dependencies Pull requests that update a dependency file maintenance labels Dec 6, 2024
@stasadev stasadev force-pushed the 20241206_stasadev_sqlite3 branch from 0124091 to c4b8761 Compare December 6, 2024 18:43
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a fine approach to me. I was kind of wondering about the embed option, but this is increasing us less than 1MB.

@rfay rfay merged commit 8bf20b8 into ddev:master Dec 8, 2024
20 checks passed
@rfay rfay deleted the 20241206_stasadev_sqlite3 branch December 8, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants