fix: Improve clarity in explanation by removing awkward 'normally', fixes #6723 #6724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasadev
requested changes
Nov 14, 2024
pkg/ddevapp/hostname_mgt.go
Outdated
| @@ -255,7 +255,7 @@ func runCommandWithSudo(args []string) (out string, err error) { | |||
| c = []string{"gsudo.exe"} | |||
| } | |||
| c = append(c, args...) | |||
| output.UserOut.Printf("DDEV needs to run with administrative privileges.\nThis is normally to add unresolvable hostnames to the hosts file.\nYou may be required to enter your password for sudo or allow escalation.\nDDEV is about to issue the command:\n %s\n", strings.Join(c, ` `)) | |||
| output.UserOut.Printf("DDEV needs to run with administrative privileges.\nThis is needed to add unresolvable hostnames to the hosts file.\nYou may be required to enter your password for sudo or allow escalation.\nDDEV is about to issue the command:\n %s\n", strings.Join(c, ` `)) | |||
There was a problem hiding this comment.
Thanks for the suggestion!
However, using "needed" right after "needs" feels a bit repetitive.
I think it would be better with "necessary" or "typically" instead.
…ording The text now states the purpose directly, which is clearer for users.
|
Download the artifacts for this pull request:
See Testing a PR.
|
|
Oh, please don't use |
stasadev
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
Text change