build: add bash-completion to standard packages #6575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially to make git completion work inside web container
github-actions
bot
added
dependencies
|
Download the artifacts for this pull request:
See Testing a PR.
|
|
Woot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Some people use git inside the container, and I note that git autocompletion doesn't work there.
Because bash completion is not installed, it's likely that plenty of other autocompletes don't work
How This PR Solves The Issue
Add bash-completion.
Manual Testing Instructions
Check out something inside the container and use git completion, especially of branches. For example, clone https://github.com/ddev/ddev and
git checkout 202409and hit tab to get suggested branches.Release/Deployment Notes
This seems to add less than 1 MB to the image size, see https://hub.docker.com/r/ddev/ddev-webserver/tags