test: Fix TestAcquiaPush and TestLagoonPush, add mariadb-old clients, fixes #6295 #6304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
rfay
changed the title
|
Download the artifacts for this pull request:
See Testing a PR.
|
stasadev
approved these changes
Jun 12, 2024
|
In some ways it seems like something nobody should ever have to know about unless they're trying to solve a problem. But maybe a blog post? It does belong somewhere. |
|
I think a blog post will do the job. |
stasadev
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
ddev push acquiafails with new mariadb client:(ERROR at line 1: Unknown command '\-'.#6295neutralmysql/mysqldump in there for people in this situation, so it's now in /usr/local/mariadb-old/binAcquia uses MySQL 5.7. We were using the default MariaDB:10.11 for the TestAcquiaPush test, and of course it has the mariadb-client 10.11.8, which has the broken directive in it.
This changes the tests to use MySQL 5.7, which now gets the MySQL 5.7 client in it, which should work OK.