Remove useless phpdoc @throws

ddebin · Mar 19, 2024 · 18cc85c · 18cc85c
1 parent 087666f
commit 18cc85c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 24 deletions.
diff --git a/src/Feed.php b/src/Feed.php
@@ -5,7 +5,6 @@
 namespace AtomGenerator;
 
 use DOMDocument;
-use Exception;
 use LibXMLError;
 use SimpleXMLElement;
 use Webmozart\Assert\Assert;
@@ -153,6 +152,7 @@ public function addChildrenTo(SimpleXMLElement $parent): void
 
         if (null !== $this->generator) {
             $generator = $parent->addChild('generator', htmlspecialchars($this->generator));
+            assert(null !== $generator);
             if (null !== $this->generatorVersion) {
                 $generator->addAttribute('version', $this->generatorVersion);
             }
@@ -163,6 +163,7 @@ public function addChildrenTo(SimpleXMLElement $parent): void
 
         foreach ($this->customElements as $customElement) {
             $element = $parent->addChild($customElement['name'], htmlspecialchars($customElement['value']), $customElement['uri']);
+            assert(null !== $element);
             foreach ($customElement['attributes'] as $name => $value) {
                 $element->addAttribute($name, $value);
             }
@@ -173,9 +174,6 @@ public function addChildrenTo(SimpleXMLElement $parent): void
         }
     }
 
-    /**
-     * @throws Exception
-     */
     public function getSimpleXML(): SimpleXMLElement
     {
         $attributes = [];
@@ -198,9 +196,6 @@ public function getSimpleXML(): SimpleXMLElement
         return $xml;
     }
 
-    /**
-     * @throws Exception
-     */
     public function getDocument(): DOMDocument
     {
         $node = dom_import_simplexml($this->getSimpleXML());
@@ -212,8 +207,6 @@ public function getDocument(): DOMDocument
 
     /**
      * @return false|string
-     *
-     * @throws Exception
      */
     public function saveXML()
     {

diff --git a/tests/FeedTest.php b/tests/FeedTest.php
@@ -7,7 +7,6 @@
 use AtomGenerator\Entry;
 use AtomGenerator\Feed;
 use DateTime;
-use Exception;
 use InvalidArgumentException;
 use LibXMLError;
 use PHPUnit\Framework\TestCase;
@@ -25,9 +24,6 @@ final class FeedTest extends TestCase
     /** @var bool reset file contents */
     protected static $reset = false;
 
-    /**
-     * @throws Exception
-     */
     public function testFeedCreation1(): void
     {
         $feed = new Feed();
@@ -78,9 +74,6 @@ public function testFeedCreation1(): void
         self::assertXmlStringEqualsXmlFile(self::TEST_FEED_XML_PATH_1, $xml);
     }
 
-    /**
-     * @throws Exception
-     */
     public function testFeedCreation2(): void
     {
         $feed = new Feed();
@@ -113,9 +106,6 @@ public function testFeedCreation2(): void
         self::assertXmlStringEqualsXmlFile(self::TEST_FEED_XML_PATH_2, $xml);
     }
 
-    /**
-     * @throws Exception
-     */
     public function testFeedCreation3(): void
     {
         $feed = new Feed();
@@ -144,9 +134,6 @@ public function testFeedCreation3(): void
         self::assertXmlStringEqualsXmlFile(self::TEST_FEED_XML_PATH_3, $xml);
     }
 
-    /**
-     * @throws Exception
-     */
     public function testFeedCreation4(): void
     {
         $sourceFeed = new Feed();
@@ -213,8 +200,6 @@ public function testFeedCreationException3(): void
 
     /**
      * @codeCoverageIgnore
-     *
-     * @throws Exception
      */
     public function testFeedCreationException4(): void
     {