-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix local integration tests #3627
Conversation
57be6b0
to
37a77de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both work for me.
@natmegs , which cypress version are you using?
webpack/webpack.config.js
Outdated
plugins: [ | ||
new EnvironmentPlugin(["NODE_ENV", "DEBUG"]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
who is that DEBUG
for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair, removed
// be served, which causes the test to fail. This delays rebuilding the | ||
// application for a very long time when in a testing environment. | ||
const delayTime = 1000 * 60 * 60 * 5; | ||
devServer.watchOptions = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the benefit over just turning watch off entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, I just restored the config we've had. I believe we still would like to recompile the code as we adapt it. Completely disabling it would mean stoping and restarting the npm run start:testing
I have 2 browser-options to test in. If i use Electron everything works just fine. When using Chrome (which is the default for me) i get the same error as @natmegs. Is this expected? If so: can we add a hint somewhere? If not expected: i noticed that chrome switches to a route at port |
|
I'm having the same issue Natalie mentioned. |
@mperrotti @natmegs does this trick fixes that for you cypress-io/cypress#1872 (comment) ? |
5e507ca
to
7ef28fb
Compare
@nLight - that worked for me :) |
7ef28fb
to
436b0f7
Compare
Build is failing with
|
🎉 This PR is included in version 2.63.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR fixes the
testing
env for integration testsand puts some ducks in the row around naming conventions in the npm scripts.
Testing
Testing OSS:
npm config delete externalplugins
- to disable pluginsnpm run start:testing
npx cypress open
Testing EE:
npm config set externalplugins <path>
- to enable pluginsnpm run test:integration:plugins:setup
- to copy plugins test. Workaround for cypressnpm run start:testing
npx cypress open
Both should be working
Trade-offs
I couldn't hold myself from cleaning up documentation/scripts
Dependencies
https://github.com/mesosphere/dcos-ui-plugins-private/pull/934