multi-region: conditional bootstrap #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this is not changed, terraform will report this errors below:
Error: Error refreshing state: 7 error(s) occurred:
* module.spoke-1.module.dcos-infrastructure.module.dcos-bootstrap-instance.output.public_ip: At column 44, line 1: list \"module.dcos-bootstrap-instance.public_ips\" does not have any elements so cannot determine type. in:
${module.dcos-bootstrap-instance.public_ips[0]}
* module.vpc-peering.aws_route.this_routes_cross_region: aws_route.this_routes_cross_region: value of 'count' cannot be computed
* module.vpc-peering.aws_route.peer_routes_region: aws_route.peer_routes_region: value of 'count' cannot be computed
* module.vpc-peering.aws_route.this_routes_region: aws_route.this_routes_region: value of 'count' cannot be computed
* module.spoke-1.module.dcos-infrastructure.module.dcos-bootstrap-instance.output.private_ip: At column 45, line 1: list \"module.dcos-bootstrap-instance.private_ips\" does not have any elements so cannot determine type. in:
${module.dcos-bootstrap-instance.private_ips[0]}
* module.vpc-peering.aws_route.peer_routes_cross_region: aws_route.peer_routes_cross_region: value of 'count' cannot be computed
* module.spoke-1.module.dcos-infrastructure.module.dcos-bootstrap-instance.output.instance: At column 43, line 1: list \"module.dcos-bootstrap-instance.instances\" does not have any elements so cannot determine type. in:
${module.dcos-bootstrap-instance.instances[0]}
"
fatz
reviewed
Jan 10, 2019
| } | ||
|
|
||
| output "private_ip" { | ||
| description = "List of private ip addresses created by this module" | ||
| value = "${module.dcos-bootstrap-instance.private_ips[0]}" | ||
| value = "${element(concat(module.dcos-bootstrap-instance.private_ips, list("")), 0)}" |
There was a problem hiding this comment.
oh I see the concat is meant to be used while destroying... do I get this right?
There was a problem hiding this comment.
when the bootstrap is conditionally created in the case of the multi-region environment where it pull the bootstrap from a remote region, having an empty object in an array throws an error. More info on this here: hashicorp/hil#50
The workaround in terraform is to always add a list("") and have it return that instead in the event an empty list exist.
There was a problem hiding this comment.
And this specific comment as well hashicorp/terraform#16580 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds control to enable a bootstrap node on the remote region