-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deserialize for array groups with optional fields #204
Conversation
Edit: Done |
This will also be useful for when we generate conway.cddl. And any time regenerating things from alonzo/babbage without needing to hand-edit the optional field for the tx outputs. |
Can we be sure to update the docs if relevant when we add new features? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like one test is failing:
test test::rust_wasm_split ... FAILED
@SebastienGllmt I don't think the docs need changing, at least in its current format. We still don't support deserialization for 100% of types, although it is much, much better now, so I think the current statement of |
8eb36fc
to
71f5cce
Compare
Fixes #203
Fixes #154 as this issue popped up while making sure optional fields were very well supported.