Extern macro CLI options for WASM boilerplate #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* --wasm-cbor-json-api-macro Override for the CBOR to/from bytes API + to/from JSON * --wasm-conversions-macro Override for the conversion traits between wasm/rust types. (e.g. From between them + AsRef for the rust one) This will help compatibility for CML and make changing any details of these only require changing those macros instead of needing to regenerate the library again. This also significantly decreases the amount of repetitive boilerplate junk making reading the files clearer.
|
This is kind of like what we had in CSL with |
rooooooooob
added
the
Quality-of-life feature
gostkin
approved these changes
Jul 26, 2023
|
@rooooooooob could you pls fix the pipeline as well? |
|
@gostkin I can try. I looked into it a few days ago but it's coming from our dependencies. It was failing before this PR. I don't get it locally so I'm guessing it's different versions of the dependencies/subdependencies or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extern macro CLI option for WASM boilerplate
This will help compatibility for CML and make changing any details of
these only require changing those macros instead of needing to
regenerate the library again.
This also significantly decreases the amount of repetitive boilerplate
junk making reading the files clearer.
--wasm-cbor-json-api-macro
Override for the CBOR to/from bytes API + to/from JSON
--wasm-conversions-macro
Override for the conversion traits between wasm/rust types. (e.g. From
between them + AsRef for the rust one)