Better enum deserialization #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #194 This helps avoid any type/group choice from eating any errors on variants as instead of receiving a NoVariantMatched you will receive one with errors as to why each variant failed. This drastically helps debugging and also works for nested choices as well.
Fixes #145 When all variants have non-overlapping first CBOR type we can avoid brute-force trying all possible variants for type/group choices and instead branch on raw.cbor_type() to only try the variant that makes sense.
SebastienGllmt
approved these changes
Jul 19, 2023
rooooooooob
added a commit
that referenced
this pull request
Apr 9, 2024
Caused when the inlining would made cddl-codegen think that the types were not overlapping since it was looking at the stored type not the actual starting cbor type (e.g. when it was a fixed value). This would cause a problem as the type matching introduced in #199 but only in very specific cases with basic groups starting with fixed values.
rooooooooob
added a commit
that referenced
this pull request
May 18, 2024
* Fix issue with overlapping inlined basic embedded enums Caused when the inlining would made cddl-codegen think that the types were not overlapping since it was looking at the stored type not the actual starting cbor type (e.g. when it was a fixed value). This would cause a problem as the type matching introduced in #199 but only in very specific cases with basic groups starting with fixed values. * Fix #229 Possibly needs more tests covering combinations with non-basic groups mixed with basic, tagged basic groups and optional fields (should work though) * Fix #230 #231 #232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together these fix #194 and #145
NoVariantMatchedWithCauses deser error variant
Addresses #194
This helps avoid any type/group choice from eating any errors on
variants as instead of receiving a NoVariantMatched you will receive one
with errors as to why each variant failed.
This drastically helps debugging and also works for nested choices as
well.
Avoid try-all on enums with non-overlapping CBOR
Fixes #145
When all variants have non-overlapping first CBOR type we can avoid
brute-force trying all possible variants for type/group choices and
instead branch on raw.cbor_type() to only try the variant that makes
sense.