Always check read_len's remaining length in structs #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this fixes #171 we still have the issue in #175 remaining. It is only an issue when you have overlapping variants AND they are inlined. When they're merely overlapping (e.g. shelley vs alonzo tx outs) this PR fixes the issue. When they were never overlapping (regardless of if inlined) then there was never an issue in the first place. |
gostkin
reviewed
Apr 19, 2023
|
|
||
| #[test] | ||
| fn overlapping_inlined() { | ||
| // this test won't work until https://github.com/dcSpark/cddl-codegen/issues/175 is resolved. |
There was a problem hiding this comment.
should we say sth about this limitation in the docs as well?
There was a problem hiding this comment.
It's a pretty niche limitation. I thought we agreed we'd use github issues instead of the readme to cover exactly things like this anyway?
gostkin
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171