Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunburst fixes #1481

Closed
wants to merge 6 commits into from
Closed

Conversation

ialarmedalien
Copy link
Contributor

This fixes #1467, the absent transitions in the sunburst chart. Includes an edit to safeArc to reorder params and remove the unnecessary i argument.

@tttp
Copy link
Contributor

tttp commented Sep 2, 2018

Hi,
Why did you upgrade grunt? is there something incompatible with the existing version?

@ialarmedalien
Copy link
Contributor Author

I ran npm audit fix after installing the various node modules as there were a number of security issues flagged; the updated grunt is probably a result of that. (Rerunning it reveals a further 27 security vulnerabilities, including six serious ones.)

@gordonwoodhull
Copy link
Contributor

This works very well! Thank you, I hope to merge this soon.

I find the history of this branch a little confusing, so I think I will just take the last commit (ccbf7c2), and do the npm updates separately. Seems to work!

Although it is important to stay up-to-date, we generally aren't exposing our users to any security vulnerabilities - these flaws invariably arise on the devDependencies side, so we may have insecure testing environments, but that's not a big deal. I don't think anyone is putting our grunt server into production. (I hope not!)

@gordonwoodhull
Copy link
Contributor

Thanks @ialarmedalien! This looks amazing, and really helps see what just happened when you filter.

Merged for 3.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants