Add Html legend support #1329
Add Html legend support #1329
Conversation
src/html-legend.js
Outdated
|
|
||
| /** | ||
| #### .horizontal([boolean]) | ||
| Display the legend horizontally instead of horizontally |
There was a problem hiding this comment.
Shouldn't this comment say 'vertically' not 'horizontally' at the end of the sentence?
There was a problem hiding this comment.
yes, will need to correct that, Thanks for pointing it out.
|
@rrameshkumar76 Thanks for your excellent work. I am currently working on upgrading dc to use D3v4 and assisting on preparing next major release of dc (version 3). You can track the progress in 3.0 branch. @gordonwoodhull has planned this PR to be part of this release. I will be working on upgrading this PR for D3v4 and readying for inclusion in dc. Will really appreciate if you are around and are able to help :) |
|
@kum-deepak Sure let me know. Thanks |
|
Many thanks! Please try rebasing you code against 3.0 branch. Let me know your results. |
|
Update you npm modules after the rebase (version of d3 has changed). $ npm i |
|
Will try and let you know of the results. |
|
@rrameshkumar76 Please check #1392, it works with D3v4, only changes are there in the specs. |
|
Merged via #1392 for 3.0.0 |
Adds a basic HTML legend supporting both vertical and horizontal legends as discussed in issue and based on previous PR by @davejlong