You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We removed crossfilter.quicksort in #1560 but the way we implemented it using Array.sort() is only compatible with numbers, not with strings.
I was looking at how hard it is to implement ordinal bar transitions for a question on SO. It's not hard, but the ordinal transition tests that modify the ordering were not working.
We removed
crossfilter.quicksort
in #1560 but the way we implemented it usingArray.sort()
is only compatible with numbers, not with strings.I was looking at how hard it is to implement ordinal bar transitions for a question on SO. It's not hard, but the ordinal transition tests that modify the ordering were not working.
In order to work with both strings and numbers,
should be
so that it does not return
NaN
s (which effectively disable ordering).The text was updated successfully, but these errors were encountered: