oops we still test d3v4 - check version in test

dc-js · Jan 28, 2019 · ec83974 · ec83974
1 parent 0202636
commit ec83974
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/spec/color-spec.js b/spec/color-spec.js
@@ -59,7 +59,11 @@ describe('dc.colorMixin', function () {
             // GIGO: mapping ordinal domain to linear scale is nonsensical
             // d3 pre-5.8: scaled to NaN and corrected to black; 5.8+: scale returns undefined
             chart.linearColors(['#ff0000','#00ff00']);
-            expect(colorTest(chart, domain)).toEqual([undefined, undefined, undefined, undefined, undefined]);
+            if (compareVersions(d3.version, '5.8') === -1) {
+                expect(colorTest(chart, domain)).toMatchColors(['#000000', '#000000', '#000000', '#000000', '#000000']);
+            } else {
+                expect(colorTest(chart, domain)).toEqual([undefined, undefined, undefined, undefined, undefined]);
+            }
         });
     });
     describe('with numeric domain' , function () {