Skip to content

Commit

Permalink
Remove brush handles for scatter-plot
Browse files Browse the repository at this point in the history
  • Loading branch information
kum-deepak committed Apr 14, 2018
1 parent b1f77ba commit 4ee0146
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions spec/scatter-plot-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,11 @@ describe('dc.scatterPlot', function () {
chart.redraw();
});

it('should not create brush handles', function () {
var selectAll = chart.select('g.brush').selectAll('path.custom-brush-handle');
expect(selectAll.size()).toBe(0);
});

it('should filter dimensions based on the same data', function () {
jasmine.clock().tick(100);
expect(otherDimension.top(Infinity).length).toBe(3);
Expand Down
2 changes: 1 addition & 1 deletion src/scatter-plot.js
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ dc.scatterPlot = function (parent, chartGroup) {
_symbol.size(oldSize);
}

_chart.setHandlePaths = function () {
_chart.createBrushHandlePaths = function () {
// no handle paths for poly-brushes
};

Expand Down

0 comments on commit 4ee0146

Please sign in to comment.