feature/dbt-expectations-shim #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unsure why CircleCi is failing. Happy to make adjustments to my PR if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address Issue #29
This PR adds a folder for shims of dbt-expectations macros. Specifically, this PR only adds a spark shim for the
regexp_instrmacro. This may be expanded in future PRs to add other shims for macros within this package.I did not add anything to the integration_tests folder. Let me know if there are any updates needed on my end for this to be incorporated. A working implementation currently exists within the Fivetran dbt_google_ads_source package. The intention will be to remove this macro from the Fivetran package and into spark-utils for use by all.