Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created VE sidebar #6892

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Created VE sidebar #6892

merged 7 commits into from
Feb 12, 2025

Conversation

nataliefiann
Copy link
Contributor

What are you changing in this pull request and why?

I have created this PR after being given the go ahead from Greg McKeon to add the VE to the sidebar

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

@nataliefiann nataliefiann requested a review from a team as a code owner February 10, 2025 12:16
Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Feb 11, 2025 4:57pm

@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Feb 10, 2025
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nataliefiann , great to see this move to the sidebar!

i believe you’ve nested the visual editor docs under the ide docs in the sidebar.js file.
if you want to add another visual editor subfolder below the ide one, you need to add the below code after the dbt cloud ide/dbt copilot section (line ~310 i think), and not within the dbt cloud ide code.

},
{
          type: "category",
          label: "dbt Cloud Visual Editor",
          collapsed: true,
          link: { type: "doc", id: "docs/cloud/visual-editor" },
          items: [
            "docs/cloud/visual-editor",
            "docs/cloud/use-visual-editor",
            "docs/cloud/visual-editor-interface",
          ],
        },
        ],
      },

also, i think you need to update the
pagination_next: "docs/cloud/use-visual-editor"
pagination_prev: "docs/cloud/visual-editor" frontmatter so the ‘next/previous’ links flow better because currently it mismatches with what’s on the sidebar

website/sidebars.js Outdated Show resolved Hide resolved
@nataliefiann nataliefiann dismissed mirnawong1’s stale review February 12, 2025 09:57

I have rolled in her feedback

@nataliefiann nataliefiann merged commit 2b48921 into current Feb 12, 2025
7 checks passed
@nataliefiann nataliefiann deleted the nfiann-VE-sidebar branch February 12, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants