Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarifies mf timespine & creates mini guide #6836
base: current
Are you sure you want to change the base?
clarifies mf timespine & creates mini guide #6836
Changes from 3 commits
674eb1e
7961004
91247ad
d0768b0
c278a82
7145d14
15ec294
c879246
7f449bb
64f114d
5c67def
d027884
5c3af77
b57e449
eab8830
8ab5852
869efac
b3e28bb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patkearns10 , i think maybe lines 133-143 dont make sense. i probably should just start with 144, query
![Screenshot 2025-02-07 at 17 23 16](https://private-user-images.githubusercontent.com/89008547/411014964-fdda7088-8f6a-4de7-b16a-803a3dd5424e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODQ1MjksIm5iZiI6MTczOTM4NDIyOSwicGF0aCI6Ii84OTAwODU0Ny80MTEwMTQ5NjQtZmRkYTcwODgtOGY2YS00ZGU3LWIxNmEtODAzYTNkZDU0MjRlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE4MTcwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUyMWU1MDUwNjQwODUxMzM3MjRiMmE3MzYzOTc0ZGNmZDcxZDhjMjJkZjdhMTY2YzNjYjMzMTJhY2EzM2IzNWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.2pxZqE4JOt62xmcRQA1-cr7dhySXYWb_dhhqdfdoQpw)
dbt sl query --metrics revenue --group-by metric_time
-- does that make sense to you in terms of how to test the .sql and yaml file work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eh, I can imagine most people are building the time spine for the first time. And it will fail if they do not run that time spine model.
Why do you want to not include those lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it's because when i ran dbt run, i didn't see anything that confirmed it for me -- maybe in just the compiled code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought we could do this based on this example but when i tested it, it only returned date_day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you get this working? I would be happy to hop on a call and co-dev-test together if you can find overlapping time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the ide doesn't support
metric_time__hour
-- is this right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or should i scrap this section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think the IDE supports
metric_time__hour
, why do you say otherwise?You could try
dbt sl list dimensions --metrics revenue