Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add visibility to where filter and clarify where text #6774

Merged
merged 41 commits into from
Jan 16, 2025

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Jan 15, 2025

this pr clarifies where help text to correct description and makes where filter query example more visible. raised in internal slack thread and related to dbt-labs/metricflow#1392


🚀 Deployment available! Here are the direct links to the updated files:

mirnawong1 and others added 29 commits June 11, 2024 10:15
this pr adds a 'interact w dbt cloud features' section (or new page) to explorer. it sets to give users clear info on how/where  they can access explorer from diff dbt cloud product/feature areas.
this pr continue's @dbeatty10 's [pr](#5641) and adds Analysis
Saved query, and Unit tests to the nodes table.

Resolves #5648
clarifies where help text to correct description and makes where filter query example more visible
@mirnawong1 mirnawong1 requested a review from a team as a code owner January 15, 2025 10:38
@github-actions github-actions bot added size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Jan 15, 2025
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely helps make it more visible, thank you!! Left one comment where I noticed a syntax issue

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thanks for creating this PR. I was having some issues testing the examples in my instance and the DX instance so you may need another set of eyes on this.

Other than that, I've left some non-blocking suggestions and approved this for you.

Kind Regards
Natalie

@mirnawong1 mirnawong1 enabled auto-merge January 16, 2025 11:58
@mirnawong1 mirnawong1 merged commit d33036f into current Jan 16, 2025
8 checks passed
@mirnawong1 mirnawong1 deleted the mirnawong1-patch-26 branch January 16, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants