Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options for retaining previous behavior of dbt deps for v1.7+ #5659

Merged
merged 14 commits into from
Jun 18, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Jun 14, 2024

Previews

What are you changing in this pull request and why?

Resolves #5140

Problem

The default behavior of dbt deps changed in v1.7+, which can be surprising to long-time users of dbt deps.

Solution

Document this in both the migration guide for v1.7 and anywhere else it is applicable (like here and/or here).

Checklist

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 10:32am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jun 14, 2024
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Jun 14, 2024
@dbeatty10 dbeatty10 changed the title Options for retaining previous behavior of dbt deps Options for retaining previous behavior of dbt deps for v1.7+ Jun 14, 2024
@dbeatty10 dbeatty10 marked this pull request as ready for review June 14, 2024 17:40
@dbeatty10 dbeatty10 requested a review from a team as a code owner June 14, 2024 17:40
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and correlates to this too: https://docs.getdbt.com/reference/commands/deps#predictable-package-installs. i just made some small tweaks to break up the paragraphs so it was easy to read/scan.

@@ -68,6 +68,8 @@ The `package-lock.yml` file should be committed in Git initially, and then updat

The `package-lock.yml` file includes a `sha1_hash` of the `packages` config. This enables dbt to detect if the `packages` config has been updated, and to rerun dependency resolution. To only check for changes to the `packages` config and update the lock file accordingly without installing those packages, provide the `--lock` flag (that is, `dbt deps --lock`).

### Forcing upgrades
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Jun 18, 2024
@mirnawong1 mirnawong1 enabled auto-merge (squash) June 18, 2024 10:20
@mirnawong1 mirnawong1 merged commit e2b532a into current Jun 18, 2024
11 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty10-patch-1 branch June 18, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Default behavior of dbt deps changed in v1.7
2 participants