Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model contracts: breaking change detection should raise an error for versioned models, otherwise a warning #4000

Closed
FishtownBuildBot opened this issue Aug 31, 2023 · 1 comment · Fixed by #4013
Closed

Model contracts: breaking change detection should raise an error for versioned models, otherwise a warning #4000

FishtownBuildBot opened this issue Aug 31, 2023 · 1 comment · Fixed by #4013
Assignees
@mirnawong1
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.7 Docs impact for the v1.7 release (Oct 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Milestone
dbt Core v1.7 Doc...

Comments

@FishtownBuildBot
Copy link

At a minimum, update body to include a link to the page on docs.getdbt.com requiring updates and what part(s) of the page you would like to see updated.
@FishtownBuildBot FishtownBuildBot mentioned this issue Aug 31, 2023
Merged
4 tasks
@MichelleArk
Copy link
Contributor

The detecting breaking changes section can be moved out of the contract page and onto the versions page: https://docs.getdbt.com/reference/resource-properties/versions

@mirnawong1 mirnawong1 mentioned this issue Sep 5, 2023
Merged
@mirnawong1 mirnawong1 self-assigned this Sep 5, 2023
@emmyoop emmyoop added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core labels Sep 6, 2023
@jtcohen6 jtcohen6 added the dbt-core v1.7 Docs impact for the v1.7 release (Oct 2023) label Sep 11, 2023
mirnawong1 added a commit that referenced this issue Sep 13, 2023
@mirnawong1
clarify unversioned models error and move to another page (#4013)
501bcb8 
Moving the detecting breaking chagnes section from the `contract` page
--> `versions` page.

Closes #4000
@jtcohen6 jtcohen6 changed the title Docs Changes Needed from dbt-core PR #8451 Model contracts: breaking change detection should raise an error for versioned models, otherwise a warning Oct 11, 2023
@jtcohen6 jtcohen6 mentioned this issue Oct 11, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirnawong1 mirnawong1

Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.7 Docs impact for the v1.7 release (Oct 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
dbt Core v1.7 Documentation
Development

Successfully merging a pull request may close this issue.

clarify unversioned models error and move to another page dbt-labs/docs.getdbt.com
5 participants
@emmyoop @MichelleArk @jtcohen6 @FishtownBuildBot @mirnawong1