dbt deps prerelease install bugs + add install-prerelease parameter to packages.yml #3624

NiallRees · 2021-07-24T15:12:08Z

Resolves #3578

Description

Adds logic to compare in semver.py to handle pre-release versions.

Checklist

I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

NiallRees · 2021-07-24T15:15:41Z

test/unit/test_semver.py

+                ['0.4.5a1', '0.4.5a2']),
+            '0.4.5a2')
+
+        self.assertEqual(


Testing the specific case raised by @lbk-fishtown in #3578

NiallRees · 2021-07-24T15:16:13Z

test/unit/test_semver.py

@@ -134,3 +136,15 @@ def test__resolve_to_specific_version(self):
                create_range(None, '<=0.0.5'),
                ['0.0.3', '0.1.4', '0.0.5']),
            '0.0.5')
+
+        self.assertEqual(
+            resolve_to_specific_version(


Testing the specific case raised in #3609

NiallRees · 2021-07-24T16:33:18Z

test/unit/test_semver.py

+            resolve_to_specific_version(
+                create_range('>=1.0.0', '<1.2.0'),
+                ['1.0.0', '1.1.0a1', '1.1.0', '1.2.0a1', '1.2.0']),
+            '1.1.0')


@jtcohen6 does the behaviour of the above four test cases make sense to you?

Those all look spot on!

NiallRees · 2021-07-24T16:34:03Z

test/unit/test_semver.py

+            resolve_to_specific_version(
+                create_range('>=1.0.0', '<1.2.0'),
+                ['1.0.0', '1.1.0a1', '1.1.0', '1.2.0a1']),
+            '1.1.0')


Enabled by https://github.com/dbt-labs/dbt/pull/3624/files#diff-b229315589aec2b4aeba481bf11d9e45d550387e96e15440f5737dac43b40df0R134-R139

jtcohen6

Heroic work @NiallRees !!

Thanks for diving into the semver logic, and big props for doing it on such a quick turnaround. We can get this in for v0.20.1—and I agree that's the right place for this. It isn't a breaking change, except in the sense of changing a behavior that's buggy + unintuitive, and this will grant package maintainers much greater peace of mind going forward.

jtcohen6 · 2021-07-28T01:53:08Z

test/unit/test_semver.py

+            resolve_to_specific_version(
+                create_range('>=1.0.0', '<1.2.0'),
+                ['1.0.0', '1.1.0a1', '1.1.0', '1.2.0a1', '1.2.0']),
+            '1.1.0')


Those all look spot on!

lbk-fishtown · 2021-07-28T01:59:26Z

Thanks Niall and Jeremy for looking into this one!

…o packages.yml (#3624) * Fix dbt deps prerelease install bugs * Add install-prerelease parameter to hub packages in packages.yml

NiallRees · 2021-07-28T08:35:52Z

CHANGELOG.md


+Contributors:
+- [@NiallRees](https://github.com/NiallRees) ([#3623](https://github.com/dbt-labs/dbt/pull/3623))


Not sure what happened here 🙈 #3639

No worries! This happens all the time...

Fix a typo introduced in #3624

…o packages.yml (#3624) * Fix dbt deps prerelease install bugs * Add install-prerelease parameter to hub packages in packages.yml automatic commit by git-black, original commits: 52ec790

NiallRees had a problem deploying to Postgres July 24, 2021 15:12 Failure

NiallRees temporarily deployed to Bigquery July 24, 2021 15:12 Inactive

cla-bot bot added the cla:yes label Jul 24, 2021

NiallRees temporarily deployed to Redshift July 24, 2021 15:12 Inactive

NiallRees temporarily deployed to Snowflake July 24, 2021 15:12 Inactive

NiallRees commented Jul 24, 2021

View reviewed changes

NiallRees had a problem deploying to Postgres July 24, 2021 16:23 Failure

NiallRees temporarily deployed to Redshift July 24, 2021 16:23 Inactive

NiallRees temporarily deployed to Bigquery July 24, 2021 16:23 Inactive

NiallRees temporarily deployed to Snowflake July 24, 2021 16:23 Inactive

NiallRees temporarily deployed to Bigquery July 24, 2021 16:27 Inactive

NiallRees had a problem deploying to Postgres July 24, 2021 16:27 Failure

NiallRees temporarily deployed to Redshift July 24, 2021 16:27 Inactive

NiallRees temporarily deployed to Snowflake July 24, 2021 16:27 Inactive

NiallRees temporarily deployed to Bigquery July 24, 2021 16:29 Inactive

NiallRees temporarily deployed to Snowflake July 24, 2021 16:29 Inactive

NiallRees had a problem deploying to Postgres July 24, 2021 16:29 Failure

NiallRees temporarily deployed to Redshift July 24, 2021 16:29 Inactive

NiallRees commented Jul 24, 2021

View reviewed changes

Fix dbt deps prerelease install bugs

590218a

NiallRees had a problem deploying to Postgres July 24, 2021 23:39 Failure

NiallRees temporarily deployed to Bigquery July 24, 2021 23:39 Inactive

NiallRees temporarily deployed to Redshift July 24, 2021 23:39 Inactive

NiallRees temporarily deployed to Snowflake July 24, 2021 23:39 Inactive

NiallRees changed the title ~~Fix dbt deps prerelease install bugs~~ dbt deps prerelease install bugs + add install-prerelease parameter to packages.yml Jul 24, 2021

Add install-prerelease parameter to hub packages in packages.yml

c38216d

NiallRees had a problem deploying to Postgres July 24, 2021 23:41 Failure

NiallRees temporarily deployed to Bigquery July 24, 2021 23:41 Inactive

NiallRees temporarily deployed to Redshift July 24, 2021 23:41 Inactive

NiallRees temporarily deployed to Snowflake July 24, 2021 23:41 Inactive

jtcohen6 approved these changes Jul 28, 2021

View reviewed changes

jtcohen6 merged commit 52ec790 into dbt-labs:develop Jul 28, 2021

jtcohen6 pushed a commit that referenced this pull request Jul 28, 2021

dbt deps prerelease install bugs + add install-prerelease parameter t…

7e4d0cc

…o packages.yml (#3624) * Fix dbt deps prerelease install bugs * Add install-prerelease parameter to hub packages in packages.yml

NiallRees mentioned this pull request Jul 28, 2021

Fix PR link in changelog #3639

Merged

NiallRees commented Jul 28, 2021

View reviewed changes

jtcohen6 pushed a commit that referenced this pull request Jul 28, 2021

Fix PR link in changelog (#3639)

558a6a0

Fix a typo introduced in #3624

jtcohen6 pushed a commit that referenced this pull request Jul 28, 2021

Fix PR link in changelog (#3639)

41ef632

Fix a typo introduced in #3624

NiallRees deleted the nw/dbt_deps_prerelease_bugfixes branch July 28, 2021 10:59

jtcohen6 mentioned this pull request Nov 8, 2021

[Bug] Prerelease versions of packages appear to be unavailable to dbt deps (again) #4224

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dbt deps prerelease install bugs + add install-prerelease parameter to packages.yml #3624

dbt deps prerelease install bugs + add install-prerelease parameter to packages.yml #3624

NiallRees commented Jul 24, 2021 •

edited

Loading

NiallRees Jul 24, 2021

NiallRees Jul 24, 2021

NiallRees Jul 24, 2021

jtcohen6 Jul 28, 2021

NiallRees Jul 24, 2021

jtcohen6 left a comment

jtcohen6 Jul 28, 2021

lbk-fishtown commented Jul 28, 2021

NiallRees Jul 28, 2021

jtcohen6 Jul 28, 2021


		Contributors:
		- [@NiallRees](https://github.com/NiallRees) ([#3623](https://github.com/dbt-labs/dbt/pull/3623))

dbt deps prerelease install bugs + add install-prerelease parameter to packages.yml #3624

dbt deps prerelease install bugs + add install-prerelease parameter to packages.yml #3624

Conversation

NiallRees commented Jul 24, 2021 • edited Loading

Description

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtcohen6 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lbk-fishtown commented Jul 28, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NiallRees commented Jul 24, 2021 •

edited

Loading