Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect package version being installed #3609

Closed
1 of 5 tasks
NiallRees opened this issue Jul 22, 2021 · 2 comments
Closed
1 of 5 tasks

Incorrect package version being installed #3609

NiallRees opened this issue Jul 22, 2021 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@NiallRees
Copy link
Contributor

Describe the bug

Despite having

  - package: tailsdotcom/dbt_artifacts
    version: 0.4.5a2

set in packages.yml, running dbt deps results in

Installing tailsdotcom/[email protected]
  Installed from version 0.4.5a1

Sometimes this installs 0.4.5a2, sometimes it doesn't. The same behaviour is also being seen in dbt cloud, and is causing frequent run failures. 0.4.5a2 is registered in dbt hub: https://hub.getdbt.com/tailsdotcom/dbt_artifacts/0.4.5a2/

Steps To Reproduce

➜  git:(staging) dbt deps
dbtenv info:  Using dbt 0.19.1 (set by dbt_project.yml, dbt_modules/dbt_utils/dbt_project.yml, dbt_modules/codegen/dbt_project.yml, dbt_modules/dbt_artifacts/dbt_project.yml).
Running with dbt=0.19.1
Installing fishtown-analytics/[email protected]
  Installed from version 0.3.1

Installing tailsdotcom/[email protected]
  Installed from version 0.4.5a1

Installing fishtown-analytics/[email protected]
  Installed from version 0.6.6

➜  git:(staging) cat packages.yml
# Packages can be found on https://hub.getdbt.com/.
packages:
  - package: fishtown-analytics/dbt_utils
    version: [">=0.6.5", "<0.7.0"]
  - package: fishtown-analytics/codegen
    version: 0.3.1
  - package: tailsdotcom/dbt_artifacts
    version: 0.4.5a2

Expected behavior

0.4.5a2 to be installed consistently

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: ____________)

The output of dbt --version:

0.19.1

The operating system you're using:
Mac
The output of python --version:
3.8.9

@NiallRees NiallRees added bug Something isn't working triage labels Jul 22, 2021
@jtcohen6
Copy link
Contributor

@NiallRees You're totally right, this is a bug in dbt's registry-based deps today: it doesn't treat prerelease versions properly. We just opened #3578 for this last week, where I included a few links to the codepaths involved, so I'm going to close this issue as a dupe.

If you have the chance to check that out, and think it might be a feasible contribution, I'd very much welcome a PR for it. The code change may be tricky but should be fairly well self-contained.

@jtcohen6 jtcohen6 added duplicate This issue or pull request already exists and removed triage labels Jul 22, 2021
@NiallRees
Copy link
Contributor Author

@NiallRees You're totally right, this is a bug in dbt's registry-based deps today: it doesn't treat prerelease versions properly. We just opened #3578 for this last week, where I included a few links to the codepaths involved, so I'm going to close this issue as a dupe.

If you have the chance to check that out, and think it might be a feasible contribution, I'd very much welcome a PR for it. The code change may be tricky but should be fairly well self-contained.

Thanks Jeremy I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants