Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including the escape single quotes warning in the next 0.9 release #728

Closed
wants to merge 5 commits into from
Closed

Including the escape single quotes warning in the next 0.9 release #728

wants to merge 5 commits into from

Conversation

jsnb-devoted
Copy link

@jsnb-devoted jsnb-devoted commented Nov 23, 2022 •
edited
Loading

Not sure how the release process works. This is just an attempt to get the escape quotes warning out of the next 0.9 release.

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

Maayan-s and others added 5 commits September 20, 2022 07:34
@Maayan-s
Update from template to dbt copyright (dbt-labs#647)
ba7ee52 
* Update from template to dbt copyright

I want to give proper attribution and licensing to code from dbt_utils that I'm using, so made this fix. Hope it's ok.

* Update LICENSE
@elyobo
Correct link from README to the CONTRIBUTING guide. (dbt-labs#687)
7172546
@alexmalins
fix typo (dbt-labs#688)
1c8996e 
Co-authored-by: Alex Malins <[email protected]>
@zachoj10
Change escape_single_quotes Reference in Pivot Macro (dbt-labs#692)
0d1b202 
* Update pivot.sql

* Changelog Updates
@jsnb-devoted
Merge branch '0.9.latest' into dev/0.9.3
59a7bc5
@joellabes joellabes mentioned this pull request Nov 25, 2022
Closed
5 tasks
@jsnb-devoted
Copy link
Author

@joellabes -- let me know if I can do anything to help get this thru. There were a couple commits in here that I didn't expect so see and I added an entry in the changelog for the hypothetical 9.6 release. Not sure if that all follows the process.

@joellabes
Copy link
Contributor

Thanks @jsnb-devoted, just released a fix for this separately 🙏

@joellabes joellabes closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jsnb-devoted @joellabes @Maayan-s @elyobo @alexmalins @zachoj10