-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update connections.py so it doesn’t run anything after its canceled #716
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @julio-romero |
@julio-romero Could you please add a changie for this update? I would classify this as a bug in the changie. |
@julio-romero and @mikealfare I just pushed two changes:
I didn't give a ton of thought to the verbiage in the changelog entry, so feel free to update it as-needed. |
Integration tests are getting skipped. I created a branch with these changes in Results: ✅ |
Can somebody test this on a real snowflake model and verify that the fix actually works? I wasn't able to get my local build of the dbt-snowflake adapter actually working. |
…716) * Update connections.py so it doesn’t run anything after its canceled * Update expected cancellation query * Changelog entry --------- Co-authored-by: Mike Alfare <[email protected]> Co-authored-by: Doug Beatty <[email protected]> (cherry picked from commit fd28b35)
…716) (#738) * Update connections.py so it doesn’t run anything after its canceled * Update expected cancellation query * Changelog entry --------- Co-authored-by: Mike Alfare <[email protected]> Co-authored-by: Doug Beatty <[email protected]> (cherry picked from commit fd28b35) Co-authored-by: julio-romero <[email protected]>
…bt-labs#716) * Update connections.py so it doesn’t run anything after its canceled * Update expected cancellation query * Changelog entry --------- Co-authored-by: Mike Alfare <[email protected]> Co-authored-by: Doug Beatty <[email protected]>
resolves #711
docs
Problem
The queries arent cancelled after typing ctrl + c in console, this might have several performance issues
Solution
Changed the cancel command from
system$abort_session(session_id)
to
system$cancel_all_queries(session_id)
Checklist