Add query_id to adapter payload and tests. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
approved these changes
Mar 14, 2022
4 tasks
VersusFacit
added a commit
that referenced
this pull request
Mar 29, 2022
* use checks over code and rewrite repo to conform to style conventions * Add query_id to adapter payload and tests. (#109) * Mix in released snowflake 1.1.0b1 * Resolve a Black library issue
1 task
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completes #40
resolves #7
Description
See PR for more details. I've optimized the types to avoid false-positives due to truthi-strings. I pushed this over the finish line with all credit given to those behind the code since some users have been asking for this in GitHub and Slack.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-snowflake next" section.