Fix plurals in FoundStats message

[jtcohen6]

resolves #9464

Problem

As part of moving the event system & log formatting logic into dbt-common, we introduced a "cosmetic regression" that prints the plural of analysis as analysiss in the FoundStats line.

Solution

Following the new logic in dbt_common.events.format.pluralize, pass the NodeType enum object into pluralize, rather than its (manually mapped) string name.

While this fixes the issue with analyses, it does mean that we'll be printing multi-word node types with an underscore instead of a space:

... data_tests, ... saved_queries, ... semantic_models, ... unit_tests

I think that's fine — it's more consistent with how these appear elsewhere — and it's definitely better than saved querys ;)

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
• This PR includes type annotations for new and modified functions

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1cbc6d3) 87.89% compared to head (5b0930b) 87.90%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9465      +/-   ##
==========================================
+ Coverage   87.89%   87.90%   +0.01%     
==========================================
  Files         164      164              
  Lines       21967    21966       -1     
==========================================
+ Hits        19307    19310       +3     
+ Misses       2660     2656       -4     

Flag	Coverage Δ
integration	85.37% <100.00%> (+0.01%)	⬆️
unit	62.48% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aranke]

Tests should pass now, thanks for adding this in!