Support longer unit test names + improve error handling in unit test construction #9396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9015
Problem
On Postgres, even modestly long test names (~20 characters) were hitting the "Relation name '{}' is longer than 63 characters" during construction of the 'actual' unit test result.
This is because we were creating model names and unique_ids in the unit test manifest out of the concatenation of the original model name, test name, and model being tested name to prevent key collision in the unit test manifest.
Solution
Now that we are creating a unit test manifest per unit test definition, there is no risk of key collisions if we just use the model name! This PR propagates those changes through and adds tests to ensure expected behaviour when:
Checklist