Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Bigquery google-api-core max version dependency #4192

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Change Bigquery google-api-core max version dependency #4192

merged 2 commits into from
Nov 3, 2021

Conversation

leahwicz
Copy link
Contributor

@leahwicz leahwicz commented Nov 2, 2021

resolves #4171

Description

The latest version of google-api-core that was released last month (1.31.3) capped the version of protobuf (3.18.0) b/c protobuf dropped Python 2.7 support. proto-plus==1.19.7 that is used by google-cloud-bigquery==2.29.0 requires protobuf>=3.19.0. 😢

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Nov 2, 2021
@leahwicz leahwicz assigned kwigley and jtcohen6 and unassigned kwigley and jtcohen6 Nov 2, 2021
@leahwicz leahwicz requested review from jtcohen6 and kwigley November 2, 2021 23:06
@leahwicz
Copy link
Contributor Author

leahwicz commented Nov 2, 2021

@jtcohen6 this looks to be blocking people using 0.21.0 already so that's why I have this targeting 0.21.latest so we can get it into RC1. Let me know what you think?

jtcohen6
jtcohen6 approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense to me. Thanks for jumping on this @leahwicz! Let's get it into the RC.

Should we be making the same change over in dbt-bigquery, for the next v1 prerelease?

@leahwicz
Copy link
Contributor Author

leahwicz commented Nov 3, 2021

Should we be making the same change over in dbt-bigquery, for the next v1 prerelease?

Yes I'll do that next

@leahwicz leahwicz merged commit 5f1ccac into 0.21.latest Nov 3, 2021
@leahwicz leahwicz deleted the leahwicz/bigqueryPatch branch November 3, 2021 12:59
@leahwicz leahwicz mentioned this pull request Nov 3, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

@kwigley kwigley kwigley approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leahwicz @kwigley @jtcohen6