Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress docker-compose arg warnings. #2775

Closed
wants to merge 1 commit into from
Closed

Suppress docker-compose arg warnings. #2775

wants to merge 1 commit into from

Conversation

heisencoder
Copy link
Contributor

@heisencoder heisencoder commented Sep 18, 2020

If the user has not created a .env file, then they see warnings like
this when running docker-compose:

WARNING: The USER_ID variable is not set. Defaulting to a blank string.
WARNING: The GROUP_ID variable is not set. Defaulting to a blank string.

This fix provides defaults to docker-compose.yml to suppress this
warning.

resolves #2739
Follow-on to #2741

If the user has not created a .env file, then they see warnings like
this when running `docker-compose`:

```
WARNING: The USER_ID variable is not set. Defaulting to a blank string.
WARNING: The GROUP_ID variable is not set. Defaulting to a blank string.
```

This fix provides defaults to docker-compose.yml to suppress this
warning.

See #2739
@cla-bot cla-bot bot added the cla:yes label Sep 18, 2020
@heisencoder heisencoder changed the base branch from dev/kiyoshi-kuromiya to dev/0.18.1 September 18, 2020 19:57
@heisencoder heisencoder changed the base branch from dev/0.18.1 to dev/kiyoshi-kuromiya September 18, 2020 19:57
@beckjake
Copy link
Contributor

@heisencoder thanks for opening this!

I think this warning is fixed in 0.18.1, I just haven't pulled that particular commit in to the kiyoshi-kuromiya branch yet. See this PR: #2768

I'd like to make sure the rest of that PR gets in as well, because it has another fix for the .env file behavior on macos that tripped some folks up (I don't really use make, so I didn't notice).

@heisencoder
Copy link
Contributor Author

Actually, I just noticed that you fixed this already, so I'll drop the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't find tox config file when running make test-unit
2 participants