Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise CONTRIBUTING doc #2577

Merged
merged 5 commits into from
Jun 26, 2020
Merged

Revise CONTRIBUTING doc #2577

merged 5 commits into from
Jun 26, 2020

Conversation

jtcohen6
Copy link
Contributor

Feature request template

  • Add Are you interested in contributing this feature?

CONTRIBUTING

  • It's mostly really good! I still want to show this to some less-technical colleagues and ask where they'd feel tripped up
  • Remove the bit about forks not running all CI tests
  • Add more issue labels and descriptions
  • Move the "tools" section up higher
  • Emphasize that passing unit + Postgres integration tests are most important
  • Small copyedit changes

@jtcohen6 jtcohen6 requested a review from drewbanin June 19, 2020 19:42
@cla-bot cla-bot bot added the cla:yes label Jun 19, 2020
drewbanin
drewbanin reviewed Jun 19, 2020
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I'm not approving yet b/c you should definitely get some other eyes on it, but all good from my perspective except where noted

@jtcohen6 jtcohen6 requested a review from drewbanin June 25, 2020 14:31
@jtcohen6
Copy link
Contributor Author

I incorporated feedback from @sanjanasen96 and @aescay. It's still not perfect, but I think this is a step forward.

drewbanin
drewbanin approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

CONTRIBUTING.md
@@ -97,7 +130,7 @@ brew install postgresql

### Installation

First make sure that you set up your `virtualenv` as described in section _Setting up an environment_. Next, install dbt (and it's dependencies) with:
First make sure that you set up your `virtualenv` as described in section _Setting up an environment_. Next, install dbt (and its dependencies) with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't you

@jtcohen6 jtcohen6 merged commit 7fa6a36 into dev/marian-anderson Jun 26, 2020
@jtcohen6 jtcohen6 deleted the refactor/contributing branch June 26, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtcohen6 @drewbanin