Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--threads does not override the max number of connections in the default adapter #648

Closed
drewbanin opened this issue Jan 31, 2018 · 1 comment
Closed

--threads does not override the max number of connections in the default adapter #648

drewbanin opened this issue Jan 31, 2018 · 1 comment
Assignees
@beckjake
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors!
Milestone
0.10.2 - Betsy Ro...

Comments

@drewbanin
Copy link
Contributor

drewbanin commented Jan 31, 2018 •
edited by beckjake
Loading 

# ~/.dbt/profiles.yml
default:
  target: dev
  outputs:
    dev:
      type: ...
      threads: 1

Invoking dbt with dbt run --threads 2 will cause an error like:

Tried to request a new connection "mode_name" but the maximum number of connections are already allocated!

dbt should prefer the --threads value if one is given, otherwise fall back to the threads option in the active target here.

Because this happens in the default adapter, it affects all adapters.
@drewbanin drewbanin added the bug Something isn't working label Jan 31, 2018
@drewbanin drewbanin added the good_first_issue Straightforward + self-contained changes, good for new contributors! label Mar 12, 2018
@cmcarthur cmcarthur added this to the 0.10.2 milestone Apr 26, 2018
@beckjake beckjake mentioned this issue Jul 3, 2018
Merged
@beckjake beckjake self-assigned this Jul 3, 2018
beckjake added a commit that referenced this issue Jul 3, 2018
@beckjake
Fix thread values to override maximum in the default adapter (#648) (#…
b20fa52 
…819)
@drewbanin
Copy link
Contributor Author

Fixed in #819 -- closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beckjake beckjake

Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Milestone
0.10.2 - Betsy Ross (Released 8/3/2018)
Development

No branches or pull requests
3 participants
@beckjake @cmcarthur @drewbanin