-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Easier switching between summary and details #52
Enhancement: Easier switching between summary and details #52
Conversation
…, and use it to toggle between summary and details
…ry, and use it in the call to compare_queries macro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! Two tweaks and then let's get it merged 🎉 @leoebfolsom, just checking that this doesn't clash with anything you've got in flight? I know you've been poking around these parts recently too
@joellabes Somewhat to my surprise since this PR is indeed in a similar spirit as mine, there don't seem to be any direct conflicts; and if I've somehow missed that, I'll be happy to incorporate these changes into mine. So, no need to worry about my PR before this one is merged. Thanks! |
Co-authored-by: Joel Labes <[email protected]>
@joellabes Everything's changed and updated! Edit:
Decided to take the most commonly found. |
Description & motivation
Issue #33 Enhancement
Changed
compare_queries()
macros to take additional argument with paramsummary
, which is set to true by default.Changed
compare_queries()
SQL to switch between summary and details SQL dependent onsummary
valueChanged
compare_relations()
macros to take additional argument with paramsummary
, which is set to true by default.Ensured
summary
argument is passed in to the call tocompare_queries()
macro within thecompare_relations()
macro.Added tests and test data for both
compare_queries
andcompare_relations
macros with and without including the summary argument.Added details on the
summary
parameter in the README.Checklist