fix: prune old versions also for views #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliansteger-sc
requested review from
jessedobbelaere,
Jrmyy,
mattiamatrix,
nicor88 and
svdimchenko
as code owners
|
Nice catch @juliansteger-sc , I believe that we can do something similar for incremental tables.. |
|
@nicor88 agreed, I didn't check this. should we do it in a follow up PR or right here? |
|
@nicor88 fucntional-tests report permissioning error |
|
@juliansteger-sc another PR for incremental models seems about right for me. Let's keep it narrow for now. |
|
@juliansteger-sc the CI is being fix. Fill free to open an issue about using this solution on incremental models. |
nicor88
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In our dbt runs we received the following error:
Debugging led to the conclusion that views are creating new versions but old views are not cleaned up.
Models used to test - Optional
dbt runwith this change they are down to last 4 glue versionsChecklist