feat: add detailed_table_type property to list_relations_without_caching function
#513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanromeo
requested review from
jessedobbelaere,
Jrmyy,
mattiamatrix,
nicor88 and
svdimchenko
as code owners
sanromeo
changed the title
detailed_table_type property to list_relations_without_caching function
|
@sanromeo nice, could you add some unit tests and functional tests if possible? For the functional tests you can add 2 models, one that is iceberg, there other calls the macro and return the detailed table type |
|
@sanromeo thanks, also have a look at the ci failures, seems that unit tests are broken |
nicor88
reviewed
Nov 18, 2023
…ithout_caching, add assertions for detailed_table_type parameter
…ns_without_caching function
|
@nicor88 I've added functional test for |
nicor88
reviewed
Nov 19, 2023
…o-list-relations-without-caching-method
…tions-without-caching-method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
dbt/adapters/athena/impl.py, I've added new parameter to additionally handle thetable_typeattribute for Iceberg tables. The update add new optional parameterdetailed_table_typewhich gets from Table["Parameters"]["table_type"] dictionary if it not exists - setdetailed_table_typetoNone.I've extended the AthenaRelation class in
dbt/adapters/athena/relation.pyto include a new optional attributedetailed_table_type. This attribute holds the specific type of table as described in the table's parameters in the Glue Catalog, providing more detailed context about the Athena relation.Resolves: #511
Checklist